From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] UDF - use UDF_MAX_WRITE_VERSION instead of numbers
Date: Sun, 13 Apr 2008 13:50:29 +0200 [thread overview]
Message-ID: <20080413115025.GA6488@joi> (raw)
In-Reply-To: <20080412194008.GB8388@cvg>
On Sat, Apr 12, 2008 at 11:40:08PM +0400, Cyrill Gorcunov wrote:
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>
> Jan, the patch is over current yours for_mm branch
>
> Yep, i know it exceeds 80 column *but* it looks much better
> in this way ;)
>
> Index: linux-2.6.git/fs/udf/inode.c
> ===================================================================
> --- linux-2.6.git.orig/fs/udf/inode.c 2008-04-12 22:53:15.000000000 +0400
> +++ linux-2.6.git/fs/udf/inode.c 2008-04-12 23:34:28.000000000 +0400
> @@ -1732,7 +1732,7 @@ int8_t udf_add_aext(struct inode *inode,
> }
> if (epos->bh) {
> if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
> - UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
> + UDF_SB(inode->i_sb)->s_udfrev >= UDF_MAX_WRITE_VERSION)
> udf_update_tag(epos->bh->b_data, loffset);
> else
> udf_update_tag(epos->bh->b_data,
I think this patch is wrong. Right now it doesn't change anything, but in future
when someone will add support for writing UDF > 2.01 (and bump UDF_MAX_WRITE_VERSION)
it will break for filesystems written with udfrev >= 2.01 && udfrev < UDF_MAX_WRITE_VERSION.
Marcin
next prev parent reply other threads:[~2008-04-13 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 19:40 [PATCH] UDF - use UDF_MAX_WRITE_VERSION instead of numbers Cyrill Gorcunov
2008-04-13 11:50 ` Marcin Slusarz [this message]
2008-04-13 12:06 ` Cyrill Gorcunov
2008-04-13 13:56 ` Marcin Slusarz
2008-04-13 14:57 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413115025.GA6488@joi \
--to=marcin.slusarz@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.