From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jl3lR-0001Hi-PR for mharc-grub-devel@gnu.org; Sun, 13 Apr 2008 11:05:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jl3lQ-0001HU-2T for grub-devel@gnu.org; Sun, 13 Apr 2008 11:05:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jl3lL-0001Fs-AK for grub-devel@gnu.org; Sun, 13 Apr 2008 11:05:03 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl3lL-0001Fi-0m for grub-devel@gnu.org; Sun, 13 Apr 2008 11:04:59 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jl3lK-0004pE-MH for grub-devel@gnu.org; Sun, 13 Apr 2008 11:04:58 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jl3lE-0006cP-Gl; Sun, 13 Apr 2008 17:04:53 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Jl3ko-000718-KE; Sun, 13 Apr 2008 17:04:26 +0200 Date: Sun, 13 Apr 2008 17:04:26 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080413150426.GB25883@thorin> References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MW5yreqqjyrRcusr" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Michael Guntsche Subject: Re: [PATCH] Fix prefix problem with LVM on RAID X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 15:05:04 -0000 --MW5yreqqjyrRcusr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Feb 23, 2008 at 09:54:35PM +0100, Michael Guntsche wrote: > Hello, > > While testing a soon to be deployed setup here I noticed that grub- > setup is setting the prefix wrong if you run > LVM on Software RAID > > grub-setup -v /dev/md0 > ... > grub-setup: info: dos partition is -2, bsd partition is -2, prefix is > (md0)(fatoftheland-main)/boot/grub > ... > > As you can see the there is also (md0) in the prefix which does not > work. > Attached a small patch that fixes this problem for me. I am not sure > if it is the best way to fix it so please take a look. > If the root device is on LVM only add the LVM part if it is on RAID > only add the RAID part. Sorry for the delay in repliing. I think it's more correct this way. Does it work for you? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) --MW5yreqqjyrRcusr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="lvm_on_raid.diff" diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/i386/pc/grub-setup.c ./util/i386/pc/grub-setup.c --- ../grub2/util/i386/pc/grub-setup.c 2008-02-19 15:00:11.000000000 +0100 +++ ./util/i386/pc/grub-setup.c 2008-04-13 17:03:21.000000000 +0200 @@ -749,6 +749,7 @@ main (int argc, char *argv[]) prefix = newprefix; } + else if (dest_dev[0] == 'm' && dest_dev[1] == 'd' && dest_dev[2] >= '0' && dest_dev[2] <= '9') { --MW5yreqqjyrRcusr--