From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jl6xW-0006da-IH for mharc-grub-devel@gnu.org; Sun, 13 Apr 2008 14:29:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jl6xU-0006Yp-HN for grub-devel@gnu.org; Sun, 13 Apr 2008 14:29:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jl6xS-0006VM-UV for grub-devel@gnu.org; Sun, 13 Apr 2008 14:29:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl6xS-0006V7-Ms for grub-devel@gnu.org; Sun, 13 Apr 2008 14:29:42 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jl6xS-0007Sy-G4 for grub-devel@gnu.org; Sun, 13 Apr 2008 14:29:42 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jl6xQ-000785-Jl for grub-devel@gnu.org; Sun, 13 Apr 2008 20:29:41 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Jl6x2-0002OD-9k for grub-devel@gnu.org; Sun, 13 Apr 2008 20:29:16 +0200 Date: Sun, 13 Apr 2008 20:29:16 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080413182916.GA8899@thorin> References: <20080321151446.GA22187@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080321151446.GA22187@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] wrong CHS limit check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 18:29:44 -0000 On Fri, Mar 21, 2008 at 04:14:46PM +0100, Robert Millan wrote: > + soff = sector % data->sectors + 1; > + head = sector / data->sectors; Or rather, as pointed out by Bean on IRC: soff = ((grub_uint32_t) sector) % data->sectors + 1; head = ((grub_uint32_t) sector) / data->sectors; to avoid gratuitous 64-bit division where 32-bit is enough. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)