From: Arnd Bergmann <arnd@arndb.de>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [patch] F_GETPATH for linux
Date: Mon, 14 Apr 2008 03:00:05 +0200 [thread overview]
Message-ID: <200804140300.05719.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0804131455030.12741@alien.or.mcafeemobile.com>
On Monday 14 April 2008, Davide Libenzi wrote:
> I was working on some bsd/linux compatibility code, and I noticed that we
> do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is
> what I'm doing now, under #ifdef), but I gave a patch a shot anyway.
> Here it is, building but untested ...
I reviewed the code path for compat_sys_fcntl{,64} for this patch, looks
good in that respect.
> +error:
> + free_page((unsigned long) buf);
> + return size;
> +}
> +EXPORT_SYMBOL(fcntl_getpath);
> +
Procfs cannot be a module, and there are no other users of this function,
so why do you export it?
Arnd <><
next prev parent reply other threads:[~2008-04-14 1:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-13 22:00 [patch] F_GETPATH for linux Davide Libenzi
2008-04-14 1:00 ` Arnd Bergmann [this message]
2008-04-14 1:41 ` Davide Libenzi
2008-04-14 5:34 ` Michael Kerrisk
2008-04-14 17:42 ` Davide Libenzi
2008-04-14 6:19 ` Christoph Hellwig
2008-04-14 11:44 ` H. Peter Anvin
2008-04-14 14:48 ` Linus Torvalds
2008-04-14 17:34 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804140300.05719.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.