All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>, mingo <mingo@redhat.com>,
	tglx <tglx@linutronix.de>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for April 10 (arch/x86)
Date: Mon, 14 Apr 2008 10:30:38 +0100	[thread overview]
Message-ID: <20080414093038.GA9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080414084320.GE23259@devserv.devel.redhat.com>

On Mon, Apr 14, 2008 at 04:43:20AM -0400, Jakub Jelinek wrote:
> On Mon, Apr 14, 2008 at 10:34:40AM +0200, Ingo Molnar wrote:
> > ... but reality called in and gcc added printf format checks as a gcc 
> > extension and even modifies the code to make it safe when the user gets 
> > it "wrong".
> 
> GCC format string checking is only about warnings, GCC never modifies
> the arguments passed to make them match the format string conversions.

Actually, how hard would it be to allow new modifiers recognized by
format string checking?  Hell, even being able to teach it that (in this
family of functions) "%<d>u" should expect dma_addr_t, "%016<64>x" -
u64, etc. would solve all the problems.  Ideally we'd need something
for things like IPv4 address (__be32 expected), IPv6 address (taking
__be32 *), etc.

No magic, usual calling conventions - it'd still remain a valid C.
We can do that in sparse and just tell gcc to STFU about these warnings,
of course, but that's kind of things that is probably wanted by userland
projects as well...

BTW, ISTR FreeBSD folks carrying gcc patches in their tree for something
with similar purpose - project-specific format modifiers/specifiers.
No idea how hard it would be to generalize, though - never looked at
those in details...

  reply	other threads:[~2008-04-14  9:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10  8:14 linux-next: Tree for April 10 Stephen Rothwell
2008-04-10 10:24 ` [BUG] linux-next: Tree for April 10 - kernel panic while loading ata driver on powermac Kamalesh Babulal
2008-04-10 10:45   ` Jeff Garzik
2008-04-10 11:02     ` Kamalesh Babulal
2008-04-10 11:32     ` Alan Cox
2008-04-10 12:14       ` Jeff Garzik
2008-04-10 12:03   ` Bartlomiej Zolnierkiewicz
2008-04-10 17:14     ` Bartlomiej Zolnierkiewicz
2008-04-10 18:25       ` Kamalesh Babulal
2008-04-10 19:16         ` Bartlomiej Zolnierkiewicz
2008-04-10 17:42 ` linux-next: Tree for April 10 Greg KH
2008-04-10 18:07 ` [BUG] linux-next: April 10 - kernel oops at kmem_cache_alloc () regression from April 9 kernel Kamalesh Babulal
2008-04-11 17:56   ` Suresh Siddha
2008-04-14 13:14     ` Kamalesh Babulal
2008-04-10 19:34 ` linux-next: Tree for April 10: generic pci_enable_resources() strikes again Mariusz Kozlowski
2008-04-14  1:48   ` Stephen Rothwell
2008-04-14  4:28     ` Greg KH
2008-04-14  4:49       ` Stephen Rothwell
2008-04-10 22:07 ` linux-next: Tree for April 10 (ftrace) Randy Dunlap
2008-04-10 22:09 ` linux-next: Tree for April 10 (arch/x86) Randy Dunlap
2008-04-11  7:46   ` Ingo Molnar
2008-04-11 15:19     ` Randy Dunlap
2008-04-11 15:26       ` Al Viro
2008-04-14  8:12         ` Ingo Molnar
2008-04-14  8:22           ` Al Viro
2008-04-14  8:34             ` Ingo Molnar
2008-04-14  8:43               ` Jakub Jelinek
2008-04-14  9:30                 ` Al Viro [this message]
2008-04-14  9:37                   ` David Miller
2008-04-14  8:40       ` Jakub Jelinek
2008-04-14 22:28         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080414093038.GA9785@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.