From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JlQFb-0000ik-HM for user-mode-linux-devel@lists.sourceforge.net; Mon, 14 Apr 2008 08:05:43 -0700 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JlQEM-0004j2-2E for user-mode-linux-devel@lists.sourceforge.net; Mon, 14 Apr 2008 08:05:38 -0700 Date: Mon, 14 Apr 2008 11:03:58 -0400 From: Jeff Dike Message-ID: <20080414150358.GD7186@c2.user-mode-linux.org> References: <20080412.174733.133433510.xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080412.174733.133433510.xiyou.wangcong@gmail.com> Subject: Re: [uml-devel] [Patch] uml: compile error fix List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: WANG Cong Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net T24gU2F0LCBBcHIgMTIsIDIwMDggYXQgMDU6NDc6MzNQTSArMDgwMCwgV0FORyBDb25nIHdyb3Rl Ogo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBlcnJvcjoKPiAKPiAgIENDICAgICAgYXJjaC91 bS9rZXJuZWwvc21wLm8KPiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gL2hvbWUvd2FuZ2NvbmcvcHJv amVjdHMvbGludXgtMi42L2FyY2gvdW0va2VybmVsL3NtcC5jOjk6Cj4gaW5jbHVkZTIvYXNtL3Rs Yi5oOiBJbiBmdW5jdGlvbiDigJh0bGJfcmVtb3ZlX3BhZ2XigJk6Cj4gaW5jbHVkZTIvYXNtL3Rs Yi5oOjEwMTogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmHBhZ2Vf Y2FjaGVfcmVsZWFzZeKAmQo+IG1ha2VbMl06ICoqKiBbYXJjaC91bS9rZXJuZWwvc21wLm9dIEVy cm9yIDEKPiBtYWtlWzFdOiAqKiogW2FyY2gvdW0va2VybmVsXSBFcnJvciAyCj4gbWFrZTogKioq IFtzdWItbWFrZV0gRXJyb3IgMgo+IAo+IEFuZCBzaW5jZSBpbmNsdWRpbmcgPGxpbnV4L3BhZ2Vt YXAuaD4gaW4gPGxpbnV4L3N3YXAuaD4gd2lsbCBicmVhayBzcGFyYywKPiB3ZSBhZGQgdGhpcyAj aW5jbHVkZSBpbiB1bWwncyBvd24gaGVhZGVyLgoKU2lnaCwgQUNLLgoKSSB0b29rIGEgc3RhYiBh dCBmaXhpbmcgdGhpcyBwcm9ibGVtIGZvciByZWFsIGEgd2hpbGUgYWdvIGJ5CnVudGFuZ2xpbmcg dGhlIGhlYWRlcnMgaW52b2x2ZWQsIGJ1dCBmYWlsZWQuCgoJICAgICAgIAkgICAgICAgCQkgSmVm ZgoKLS0gCldvcmsgZW1haWwgLSBqZGlrZSBhdCBsaW51eCBkb3QgaW50ZWwgZG90IGNvbQoKLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQpUaGlzIFNGLm5ldCBlbWFpbCBpcyBzcG9uc29yZWQgYnkgdGhlIDIwMDgg SmF2YU9uZShTTSkgQ29uZmVyZW5jZSAKRG9uJ3QgbWlzcyB0aGlzIHllYXIncyBleGNpdGluZyBl dmVudC4gVGhlcmUncyBzdGlsbCB0aW1lIHRvIHNhdmUgJDEwMC4gClVzZSBwcmlvcml0eSBjb2Rl IEo4VEwyRDIuIApodHRwOi8vYWQuZG91YmxlY2xpY2submV0L2NsazsxOTg3NTc2NzM7MTM1MDMw Mzg7cD9odHRwOi8vamF2YS5zdW4uY29tL2phdmFvbmUKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KVXNlci1tb2RlLWxpbnV4LWRldmVsIG1haWxpbmcgbGlz dApVc2VyLW1vZGUtbGludXgtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlz dHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL3VzZXItbW9kZS1saW51eC1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761348AbYDNPFz (ORCPT ); Mon, 14 Apr 2008 11:05:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756371AbYDNPFr (ORCPT ); Mon, 14 Apr 2008 11:05:47 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:48036 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbYDNPFq (ORCPT ); Mon, 14 Apr 2008 11:05:46 -0400 Date: Mon, 14 Apr 2008 11:03:58 -0400 From: Jeff Dike To: WANG Cong Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [Patch] uml: compile error fix Message-ID: <20080414150358.GD7186@c2.user-mode-linux.org> References: <20080412.174733.133433510.xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080412.174733.133433510.xiyou.wangcong@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 12, 2008 at 05:47:33PM +0800, WANG Cong wrote: > > This patch fixes this error: > > CC arch/um/kernel/smp.o > In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9: > include2/asm/tlb.h: In function ‘tlb_remove_page’: > include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’ > make[2]: *** [arch/um/kernel/smp.o] Error 1 > make[1]: *** [arch/um/kernel] Error 2 > make: *** [sub-make] Error 2 > > And since including in will break sparc, > we add this #include in uml's own header. Sigh, ACK. I took a stab at fixing this problem for real a while ago by untangling the headers involved, but failed. Jeff -- Work email - jdike at linux dot intel dot com