From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Bunk <bunk@kernel.org>
Cc: hskinnemoen@atmel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] avr32: don't offer SERIAL_8250
Date: Mon, 14 Apr 2008 15:36:24 +0100 [thread overview]
Message-ID: <20080414153625.6150e999@core> (raw)
In-Reply-To: <20080414141721.GI6695@cs181133002.pp.htv.fi>
On Mon, 14 Apr 2008 17:17:21 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> CC [M] drivers/serial/8250.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/8250.c:95:24: error: asm/serial.h: No such file or directory
> make[3]: *** [drivers/serial/8250.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 3cb4ef80d75e118ccfd44f7006aea3db54afb31c diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index b1bbaa0..b0e216d 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -11,7 +11,7 @@ menu "Serial drivers"
> # The new 8250/16550 serial drivers
> config SERIAL_8250
> tristate "8250/16550 and compatible serial support"
> - depends on (BROKEN || !SPARC)
> + depends on (BROKEN || !SPARC) && !AVR32
> select SERIAL_CORE
> ---help---
NAK.
Add an asm/serial.h to the platform as it has PCI so will have 8250 PCI
devices available to it. A copy of the MIPS one should be right.
Alan
next prev parent reply other threads:[~2008-04-14 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 14:17 [2.6 patch] avr32: don't offer SERIAL_8250 Adrian Bunk
2008-04-14 14:36 ` Alan Cox [this message]
2008-04-14 18:42 ` [2.6 patch] avr32: add include/asm-avr32/serial.h Adrian Bunk
2008-04-14 21:56 ` Alan Cox
2008-04-16 5:53 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414153625.6150e999@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bunk@kernel.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.