Re: [PATCH 3/3] OLPC: gxfb/lxfb: add DCON panel modes to framebuffer drivers

[Andres Salomon <dilinger@queued.net>]

On Mon, 14 Apr 2008 18:21:12 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 14 Apr 2008 03:53:02 -0400 Andres Salomon <dilinger@queued.net> wrote:
> 
> > 
> > Since there's no way to autodetect panel modes, we're forced to hardcode
> > them in the driver and add a big fat #ifdef.  The OLPC DCON needs a
> > specific mode line (at 1200x900).  This adds it to both gxfb and lxfb.
> > 
> > ...
> >
> > +static const struct fb_videomode gx_dcon_modedb[] __initdata = {
> > +const struct fb_videomode olpc_dcon_modedb[] __initdata = {

Hm, that one should be static as well.  Will fix in the following patch.

> 
> include/linux/init.h:38 points out that `const' and `__initdata' should
> not be mixed.
> 
> I forget which architecture/compiler versions explode when we do this.  But
> it's not x86, iirc.
> 
> Still, it's poor form and, err, I don't immediately recall which tag we
> _should_ use, and the comments in there are unhelpful.  It might be
> __initconst, but that has exactly zero users.  Help.
> 


My guess would be __initconst or __devinitconst?  That would put it in
.{init,devinit}.rodata rather than .{init,devinit}.data.

Alternatively, I could just remove the 'const'.

Documentation for this stuff would be awesome.  :/



-- 
Need a kernel or Debian developer?  Contact me, I'm looking for contracts.