From: Al Viro <viro@ZenIV.linux.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH-mm 11/15] video: Use get/put_unaligned_* helpers
Date: Tue, 15 Apr 2008 00:05:57 +0100 [thread overview]
Message-ID: <20080414230557.GD9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1208213280.11920.41.camel@brick>
On Mon, Apr 14, 2008 at 03:48:00PM -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/video/matrox/matroxfb_misc.c | 28 ++++++++++++++--------------
> drivers/video/metronomefb.c | 9 +++------
> 2 files changed, 17 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/video/matrox/matroxfb_misc.c b/drivers/video/matrox/matroxfb_misc.c
> index ab7fb50..cfb5205 100644
> --- a/drivers/video/matrox/matroxfb_misc.c
> +++ b/drivers/video/matrox/matroxfb_misc.c
> @@ -522,8 +522,6 @@ static void parse_bios(unsigned char __iomem* vbios, struct matrox_bios* bd) {
> #endif
> }
>
> -#define get_u16(x) (le16_to_cpu(get_unaligned((__u16*)(x))))
> -#define get_u32(x) (le32_to_cpu(get_unaligned((__u32*)(x))))
Why not simply change definitions of those?
next prev parent reply other threads:[~2008-04-14 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 22:48 [PATCH-mm 11/15] video: Use get/put_unaligned_* helpers Harvey Harrison
2008-04-14 23:05 ` Al Viro [this message]
2008-04-14 23:13 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414230557.GD9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.