Re: [RFC] Patch to option HSO driver to the kernel

[Stephen Hemminger <shemminger@vyatta.com>]

On Tue, 15 Apr 2008 12:00:30 -0700
Greg KH <greg@kroah.com> wrote:

> On Tue, Apr 15, 2008 at 08:46:42PM +0200, Oliver Neukum wrote:
> > Am Dienstag, 15. April 2008 17:34:08 schrieb Greg KH:
> > > So I'll go delete that "special" ioctl, that's not a good thing to do,
> > > use the common interfaces that all USB devices rely on instead, don't do
> > > something different for just one type of USB device.
> > 
> > Do you have a new unified patch? I'd work against that, lest we get
> > merge troubles.
> 
> Good idea :)
> 
> Here it is.
> 
> thanks,
> 
> greg k-h
> 
> ----------------
> 
> Subject: USB: add option hso driver
> 
> This driver is for a number of different Option devices.  Originally
> written by Option and Andrew Bird, but cleaned up massivly for
> acceptance into mainline by me (Greg).
> 
> TODO:
> 	- remove proc files and move to debugfs
> 	- review network interfaces
> 	- add better changelog information

More work left:

- Use netif_msg_ for the message level rather than module parameter
- net_device_stats are now available in dev->stats
- use ethtool_ops rather than ioctl