All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Extend the code to ignore junk files
Date: Tue, 15 Apr 2008 15:20:11 +0200	[thread overview]
Message-ID: <20080415132011.GC21548@thorin> (raw)
In-Reply-To: <1208211768.3971.44.camel@localhost.localdomain>

On Tue, Apr 15, 2008 at 12:22:48AM +0200, Lubomir Kundrak wrote:
> --- grub-1.96.orig/util/update-grub_lib.in	2008-04-15 00:16:12.000000000 +0200
> +++ grub-1.96/util/update-grub_lib.in	2008-04-15 00:15:04.000000000 +0200
> @@ -115,6 +115,8 @@ grub_file_is_not_garbage ()
>    if test -f "$1" ; then
>      case "$1" in
>        *.dpkg-dist|*.dpkg-old|*.dpkg-tmp) return 1 ;; # debian dpkg
> +      *.rpmnew|*.rpmsave) return 1 ;; # Fedora rpm
> +      *.bak|*~|.*.swp) return 1 ;;    # backup and swap files from editors

This has the side-effect that Linux images whose name ends with ~ are excluded,
which is probably not that uncommon.  E.g. /boot/vmlinuz-2.6.24.foobar~

Is this really what we want?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-04-15 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 22:22 [PATCH] Extend the code to ignore junk files Lubomir Kundrak
2008-04-15 13:20 ` Robert Millan [this message]
2008-04-15 18:32   ` Chris Knadle
2008-04-15 18:56     ` Pavel Roskin
2008-04-17 16:01     ` Lubomir Kundrak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080415132011.GC21548@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.