From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JllI4-0000Yu-C0 for mharc-grub-devel@gnu.org; Tue, 15 Apr 2008 09:33:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JllI1-0000Yp-WD for grub-devel@gnu.org; Tue, 15 Apr 2008 09:33:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JllI0-0000Yc-MT for grub-devel@gnu.org; Tue, 15 Apr 2008 09:33:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JllI0-0000YZ-K9 for grub-devel@gnu.org; Tue, 15 Apr 2008 09:33:36 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JllI0-0005ZP-2w for grub-devel@gnu.org; Tue, 15 Apr 2008 09:33:36 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JllHy-0004p6-Pf for grub-devel@gnu.org; Tue, 15 Apr 2008 15:33:35 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JllHc-0005r1-Ni for grub-devel@gnu.org; Tue, 15 Apr 2008 15:33:12 +0200 Date: Tue, 15 Apr 2008 15:33:12 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080415133312.GE21548@thorin> References: <1208211148.3971.38.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1208211148.3971.38.camel@localhost.localdomain> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix file name transformations (mostly) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2008 13:33:38 -0000 On Tue, Apr 15, 2008 at 12:12:28AM +0200, Lubomir Kundrak wrote: > diff -urp grub-1.96.orig/util/update-grub.in grub-1.96/util/update-grub.in > --- grub-1.96.orig/util/update-grub.in 2008-03-16 17:52:32.000000000 +0100 > +++ grub-1.96/util/update-grub.in 2008-03-16 17:59:42.000000000 +0100 > @@ -23,7 +23,7 @@ exec_prefix=@exec_prefix@ > sbindir=@sbindir@ > libdir=@libdir@ > sysconfdir=@sysconfdir@ > -grub_prefix=`echo /boot/grub | sed ${transform}` > +grub_prefix=/boot/`echo /grub | sed ${transform}` Is the second slash intentional? > --- grub-1.96.orig/util/update-grub_lib.in.transform 2008-03-23 11:46:14.000000000 +0100 > +++ grub-1.96/util/update-grub_lib.in 2008-03-23 11:49:21.000000000 +0100 > @@ -95,7 +95,8 @@ > { > # Prefer system path for space reasons (/boot/grub might be a very small > # partition in case of OpenFirmware, etc). > - for dir in ${pkgdatadir} /usr/share/grub /boot/grub ; do > + for dir in ${pkgdatadir} ${pkgdatadir}/`echo grub | sed ${transform}` \ > + /boot/`echo grub | sed ${transform}`; do I'd prefer is grub_prefix was defined here too (for readability). -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)