From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JllJm-0000qJ-Ln for mharc-grub-devel@gnu.org; Tue, 15 Apr 2008 09:35:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JllJl-0000qB-Ad for grub-devel@gnu.org; Tue, 15 Apr 2008 09:35:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JllJj-0000pf-Db for grub-devel@gnu.org; Tue, 15 Apr 2008 09:35:24 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JllJj-0000pa-AV for grub-devel@gnu.org; Tue, 15 Apr 2008 09:35:23 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JllJi-0005vp-4t for grub-devel@gnu.org; Tue, 15 Apr 2008 09:35:22 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JllJh-0004pC-3X for grub-devel@gnu.org; Tue, 15 Apr 2008 15:35:21 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JllJN-0005rq-8d for grub-devel@gnu.org; Tue, 15 Apr 2008 15:35:01 +0200 Date: Tue, 15 Apr 2008 15:35:01 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080415133501.GF21548@thorin> References: <1208212910.3971.53.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1208212910.3971.53.camel@localhost.localdomain> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Preserve build IDs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2008 13:35:25 -0000 On Tue, Apr 15, 2008 at 12:41:50AM +0200, Lubomir Kundrak wrote: > This will make Fedora packagers have good sleep. I think we discussed > this already on the list. Rationale behind disabling build-ids > completely was that it caused images to grow a lot. Correct solution is > to disable it from images only and let it exists in elf files for > debugging purposes. > > 2008-04-15 Lubomir Kundrak > > * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): take only .text > section into account, newer toolchains generate unique build ids > * configure.ac: remove the test for --build-id=none acceptance, > we want build ids to bre preserved > * genmk.rb: add -R .note.gnu.build-id to objcopy, so build id > far from other sections don't cause the raw binary images grow > size Looks good to me. Pavel will probably know better though. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)