All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Make gdb debugging a bit less painful
Date: Tue, 15 Apr 2008 15:38:05 +0200	[thread overview]
Message-ID: <20080415133805.GG21548@thorin> (raw)
In-Reply-To: <1208212240.3971.48.camel@localhost.localdomain>

On Tue, Apr 15, 2008 at 12:30:40AM +0200, Lubomir Kundrak wrote:
> diff -rup grub-1.95.orig/kern/main.c grub-1.95/kern/main.c
> --- grub-1.95.orig/kern/main.c	2007-01-29 15:31:36.000000000 +0100
> +++ grub-1.95/kern/main.c	2007-01-30 18:29:55.000000000 +0100
> @@ -106,6 +106,14 @@ grub_load_normal_mode (void)
>    grub_errno = GRUB_ERR_NONE;
>  }
>  
> +#ifndef GRUB_UTIL
> +/*
> + * Let GDB find the stack top
> + */
> +void
> +main (void) __attribute__ ((alias("grub_main")));
> +#endif

grub_main() isn't always the function we want for top of the stack.  For
example cmain() in kern/ieee1275/cmain.c does quite a bit of things already.

I'm not sure what would be an ellegant way to solve this... :-/

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  parent reply	other threads:[~2008-04-15 13:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 22:30 [PATCH] Make gdb debugging a bit less painful Lubomir Kundrak
2008-04-15 13:21 ` Robert Millan
2008-04-15 13:38 ` Robert Millan [this message]
2008-04-17 11:53   ` Lubomir Kundrak
2008-04-17 20:11     ` Robert Millan
2008-04-18  2:21       ` Pavel Roskin
2008-04-18 11:32         ` Robert Millan
2008-04-18 12:13           ` Robert Millan
2008-04-18 15:16             ` Pavel Roskin
2008-04-18 15:36               ` Robert Millan
2008-04-18 15:38               ` Bean
2008-04-18 15:45                 ` Robert Millan
2008-04-18 13:58           ` Lubomir Kundrak
2008-04-18 15:54           ` Robert Millan
2008-04-15 19:01 ` Pavel Roskin
2008-04-17 11:54   ` Lubomir Kundrak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080415133805.GG21548@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.