From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org,
ralf@linux-mips.org
Subject: Re: [PATCH] Au1200: kill IDE driver function prototypes
Date: Tue, 15 Apr 2008 22:54:34 +0200 [thread overview]
Message-ID: <200804152254.34197.bzolnier@gmail.com> (raw)
In-Reply-To: <200804142228.51987.sshtylyov@ru.mvista.com>
On Monday 14 April 2008, Sergei Shtylyov wrote:
> Fix these warnings emitted when compiling drivers/ide/mips/au1xxx-ide.c:
>
> include/asm/mach-au1x00/au1xxx_ide.h:137: warning: 'auide_tune_drive' declared
> `static' but never defined
> include/asm/mach-au1x00/au1xxx_ide.h:138: warning: 'auide_tune_chipset' declared
> `static' but never defined
>
> by wiping out the whole "function prototyping" section from the header file
> <asm-mips/mach-au1x00/au1xxx_ide.h> as it mostly declared functions that are
> already dead in the IDE driver; move the only useful prototype into the driver.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
> ---
> I'm not sure thru which tree this should go -- probably thru Linux/MIPS one...
>
> Bart, au1xxx-ide-fix-mwdma-support.patch will probably need to be updated to
> remove that added prototype since it won't be needed anymore...
I would prefer to merge this patch thru IDE tree because of the above and
the fact that it only touches "IDE" files - I hope Ralf is fine with it.
> drivers/ide/mips/au1xxx-ide.c | 2 ++
> include/asm-mips/mach-au1x00/au1xxx_ide.h | 18 ------------------
> 2 files changed, 2 insertions(+), 18 deletions(-)
next prev parent reply other threads:[~2008-04-15 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 18:28 [PATCH] Au1200: kill IDE driver function prototypes Sergei Shtylyov
2008-04-15 20:54 ` Bartlomiej Zolnierkiewicz [this message]
2008-04-28 14:26 ` Sergei Shtylyov
2008-04-28 18:46 ` Bartlomiej Zolnierkiewicz
2008-04-28 18:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804152254.34197.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.