All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH 2/7] omfs: add inode routines
Date: Wed, 16 Apr 2008 20:31:42 +0200	[thread overview]
Message-ID: <20080416183114.GA6264@joi> (raw)
In-Reply-To: <20080415235659.GA7068@hash.localnet>

On Tue, Apr 15, 2008 at 07:56:59PM -0400, Bob Copeland wrote:
> > > +	return ret;
> > > +}
> > 
> > this code leaks omfs_sbi_info (sbi)
> 
> This one I'm not seeing.  FS core calls put_super if ret is nonzero so
> this should be ok?

Yep, you are right. Sorry for the noise.
I was mislead by other filesystems code.

Marcin

  reply	other threads:[~2008-04-16 18:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12 22:58 [PATCH 2/7] omfs: add inode routines Bob Copeland
2008-04-13  8:05 ` Christoph Hellwig
2008-04-13  9:17 ` Alan Cox
2008-04-15 18:03 ` Miklos Szeredi
2008-04-15 18:33   ` Bob Copeland
2008-04-15 18:30 ` Marcin Slusarz
2008-04-15 23:56   ` Bob Copeland
2008-04-16 18:31     ` Marcin Slusarz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-03-27  0:45 Bob Copeland
2008-03-27  6:13 ` Andi Kleen
2008-03-27 12:38   ` Bob Copeland
2008-03-28  3:42 ` Arnd Bergmann
2008-03-28  3:42   ` Arnd Bergmann
2008-03-28 13:34   ` Bob Copeland
2008-03-28 20:20 ` Pavel Machek
2008-03-30  3:21   ` Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080416183114.GA6264@joi \
    --to=marcin.slusarz@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.