From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
linux-kernel@vger.kernel.org, ebiederm@xmission.com
Subject: Re: Current git tree broke busybox start-stop-daemon
Date: Wed, 16 Apr 2008 20:34:17 +0100 [thread overview]
Message-ID: <20080416193417.GD27459@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080416190057.GA4666@martell.zuzino.mipt.ru>
On Wed, Apr 16, 2008 at 11:00:57PM +0400, Alexey Dobriyan wrote:
> On Wed, Apr 16, 2008 at 07:25:02PM +0200, Joakim Tjernlund wrote:
> > open("/proc/1/stat", O_RDONLY|O_LARGEFILE) = 4
> > _llseek(4, 0, 0xbfb94898, SEEK_END) = -1 EINVAL (Invalid argument)
>
> > So it appears that lseek is no longer allowed for /proc/1/stat
> > Bug or feature?
> > start-stop-daemon works fine in 2.6.23
>
> That's what happens when switching ->llseek method from NULL
> (effectively, default_llseek), to seq_lseek (which rejects SEEK_END).
>
> commit be614086a4aff163d5aa0dc160638d1193b59cde
> commit ee992744ea53db0a90c986fd0a70fbbf91e7f8bd
>
> Al, do you remember why SEEK_END was omitted back then?
Because there's no sane way to implement it? Note that original cheerfully
did nothing, since it had zero ->i_size for that file. Which makes program
in question very odd - what behaviour does it rely upon?
next prev parent reply other threads:[~2008-04-16 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 17:25 Current git tree broke busybox start-stop-daemon Joakim Tjernlund
2008-04-16 19:00 ` Alexey Dobriyan
2008-04-16 19:34 ` Al Viro [this message]
2008-04-16 19:47 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2008-04-16 19:04 tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416193417.GD27459@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=ebiederm@xmission.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.