Re: 2.6.25-rc8-mm1 panic in rpaphp_register_slot()

[Alex Chiang <achiang@hp.com>]

Hi Badari,

* Badari Pulavarty <pbadari@us.ibm.com>:
> 
> On Tue, 2008-04-15 at 21:18 -0600, Alex Chiang wrote:
> > >>> +	if (slot->bus->self)
> > >>> +		slot_nr = PCI_SLOT(slot->bus->self->devfn);
> > >>> +	else
> > >>> +		slot_nr = 0;
> > >>> +	retval = pci_hp_register(php_slot, slot->bus, slot_nr);
> > >>>  	if (retval) {
> > >>>  		err("pci_hp_register failed with error %d\n", retval);
> > >>>  		return retval;
> > >
> > > No. It didn't help. I had to hack "slot_nr = 0" all the time to boot my  
> > > machine.
> > 
> > It didn't help because you're still getting a NULL deref? Or are
> > you seeing some other failure mode?
> > 
> 
> I verified this patch again. It seem to have worked this time :(
> I am not able to reproduce the problem with this problem (tried many
> times). 
>  
> Sorry for the false alarm :(

Thanks for testing. Please do let me know if you see any more
problems.

Ben, I would still appreciate a code review on:

	http://lkml.org/lkml/2008/4/7/319

Thanks!

/ac