All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: apenwarr@gmail.com
Cc: git@vger.kernel.org, Avery Pennarun <apenwarr@versabanq.com>
Subject: Re: [PATCH 2/3] git-svn: Add --add-author-from option.
Date: Wed, 16 Apr 2008 21:36:20 -0700	[thread overview]
Message-ID: <20080417043620.GA11600@soma> (raw)
In-Reply-To: <1208307858-31039-2-git-send-email-apenwarr@gmail.com>

apenwarr@gmail.com wrote:
> From: Avery Pennarun <apenwarr@versabanq.com>
> 
> This adds a From: line (based on the commit's author information) when
> sending to svn.  It doesn't add if a From: or Signed-off-by: header already
> exists for that commit.
> 
> This, combined with --use-log-author, can retain the author field of commits
> through a round trip from git to svn and back.
> Signed-off-by: Avery Pennarun <apenwarr@gmail.com>

This seems like a useful feature for SVN projects and I've sometimes
wanted it myself.  Thanks.

One thing, can you add some tests to ensure this continues working?  I
don't have lots of time to work on git-svn these days and if I do, I
want it to be easy to ensure I'm not breaking things :)

Thanks.

-- 
Eric Wong

      parent reply	other threads:[~2008-04-17  4:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16  1:04 [PATCH 1/3] git-svn: add documentation for --use-log-author option apenwarr
2008-04-16  1:04 ` [PATCH 2/3] git-svn: Add --add-author-from option apenwarr
2008-04-16  1:04   ` [PATCH 3/3] git-svn: add documentation for " apenwarr
2008-04-16  4:33   ` [PATCH 2/3] git-svn: Add " Junio C Hamano
2008-04-16 16:46     ` Avery Pennarun
2008-04-16 18:36       ` Junio C Hamano
2008-04-16 18:45         ` Avery Pennarun
2008-04-16 19:11         ` Richard Quirk
2008-04-16 19:23         ` Dmitry Potapov
2008-04-16 22:24           ` Sam Vilain
2008-04-16 22:34             ` Avery Pennarun
2008-04-17  4:36   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080417043620.GA11600@soma \
    --to=normalperson@yhbt.net \
    --cc=apenwarr@gmail.com \
    --cc=apenwarr@versabanq.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.