From: Dale Farnsworth <dale@farnsworth.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing
Date: Thu, 17 Apr 2008 13:54:10 -0700 [thread overview]
Message-ID: <20080417205410.GA13452@farnsworth.org> (raw)
In-Reply-To: <4807B7F7.4020209@freescale.com>
On Thu, Apr 17, 2008 at 03:49:59PM -0500, Timur Tabi wrote:
> Dale Farnsworth wrote:
> > I find "is_brg" much more meaningful than "clk < QE_CLK1".
> >
> > Maybe the computer doesn't need it, but it's helpful to a
> > reader of the code.
>
> That's what comments are for. I'm all for self-documenting code, but not
> creating additional code to avoid comments.
Well, we disagree then. Self documenting code of this form is far
preferable to comments that communicate the same thing.
-Dale
next prev parent reply other threads:[~2008-04-17 20:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 19:26 [PATCH 0/5] Few more patches for Kumar's powerpc.git Anton Vorontsov
2008-04-17 19:28 ` [PATCH 1/5] [POWERPC] sysdev: implement FSL GTM support Anton Vorontsov
2008-04-17 22:47 ` Anton Vorontsov
2008-04-18 4:19 ` Kumar Gala
2008-04-18 9:54 ` Anton Vorontsov
2008-04-17 19:28 ` [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing Anton Vorontsov
2008-04-17 19:56 ` Timur Tabi
2008-04-17 19:59 ` Scott Wood
2008-04-17 20:04 ` Timur Tabi
2008-04-17 20:14 ` Scott Wood
2008-04-17 20:17 ` Timur Tabi
2008-04-17 20:26 ` Scott Wood
2008-04-17 20:47 ` Dale Farnsworth
2008-04-17 20:49 ` Timur Tabi
2008-04-17 20:54 ` Dale Farnsworth [this message]
2008-04-17 21:48 ` Anton Vorontsov
2008-04-17 22:00 ` Timur Tabi
2008-04-17 19:28 ` [PATCH 3/5] [POWERPC] QE: split par_io_config_pin() Anton Vorontsov
2008-04-17 21:53 ` Kumar Gala
2008-04-17 22:35 ` Anton Vorontsov
2008-04-17 19:29 ` [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API Anton Vorontsov
2008-04-17 22:35 ` Kumar Gala
2008-04-17 22:41 ` Anton Vorontsov
2008-04-18 2:21 ` Kumar Gala
2008-04-17 19:29 ` [PATCH 5/5] [POWERPC] 83xx: new board support: MPC8360E-RDK Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2008-04-18 19:06 [PATCH 0/5 v2] Few more patches for Kumar's powerpc.git Anton Vorontsov
2008-04-18 19:09 ` [PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417205410.GA13452@farnsworth.org \
--to=dale@farnsworth.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.