All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/8] builtin-clone
Date: Fri, 18 Apr 2008 03:14:31 +0200	[thread overview]
Message-ID: <200804180314.31659.johan@herland.net> (raw)
In-Reply-To: <alpine.LNX.1.00.0804172052300.19665@iabervon.org>

On Friday 18 April 2008, Daniel Barkalow wrote:
> On Fri, 18 Apr 2008, Johan Herland wrote:
> > On Friday 18 April 2008, Daniel Barkalow wrote:
> > > This is my latest version, rebased approximately on current master (or 
> > > recent maint, I guess). It's missing all of Johan's stuff, which is tests 
> > > for stuff I've fixed
> > 
> > Does this mean you no longer need the tests, or that you want me to resend?
> 
> I have them, but my patch-sending process isn't set up for sending other 
> people's patches without forging their email, and I wanted to get this 
> series out, and they're not critical, so I skipped them for now.

No problem. Feel free to do whatever you like with them. :)

> > 1. Add a command-line option (and config variable?) for controlling
> >    whether "git clone" generates packed refs.
> > 
> > 2. Make "git clone" unconditionally generate packed refs.
> > 
> > Currently, I'm leaning towards (2), [...]
> > 
> > If there are good arguments for going with (1), I'd love to hear them.
> 
> I think it's fine, actually (now that you've not test corrections that 
> work for it); but I'd like to have builtin-clone land without any changes 
> in behaviour, and then get this sort of improvement.

Yes, I agree that a pure rewrite (without changes in behaviour) should be
committed first.


Have fun :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net

      reply	other threads:[~2008-04-18  1:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 23:32 [PATCH 0/8] builtin-clone Daniel Barkalow
2008-04-18  0:50 ` Johan Herland
2008-04-18  0:56   ` Daniel Barkalow
2008-04-18  1:14     ` Johan Herland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804180314.31659.johan@herland.net \
    --to=johan@herland.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.