From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Christof Schmitt <christof.schmitt@de.ibm.com>,
Martin Peschke <mp3@de.ibm.com>
Subject: [patch 3/3] zfcp: Fix error handling for blocked unit for send FCP command
Date: Fri, 18 Apr 2008 12:51:57 +0200 [thread overview]
Message-ID: <20080418105456.235253000@de.ibm.com> (raw)
In-Reply-To: 20080418105154.135704000@de.ibm.com
[-- Attachment #1: zfcp-fix-goto-send-fcp.diff --]
[-- Type: text/plain, Size: 779 bytes --]
From: Christof Schmitt <christof.schmitt@de.ibm.com>
In the case the unit is blocked, zfcp_unit_get has not been called
yet, so the error handling path should not call zfcp_unit_put.
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Martin Peschke <mp3@de.ibm.com>
---
drivers/s390/scsi/zfcp_fsf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/s390/scsi/zfcp_fsf.c 2008-04-18 12:43:05.000000000 +0200
+++ b/drivers/s390/scsi/zfcp_fsf.c 2008-04-18 12:43:13.000000000 +0200
@@ -3562,8 +3562,8 @@ zfcp_fsf_send_fcp_command_task(struct zf
send_failed:
no_fit:
failed_scsi_cmnd:
- unit_blocked:
zfcp_unit_put(unit);
+ unit_blocked:
zfcp_fsf_req_free(fsf_req);
fsf_req = NULL;
scsi_cmnd->host_scribble = NULL;
--
prev parent reply other threads:[~2008-04-18 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 10:51 [patch 0/3] zfcp fixes Christof Schmitt
2008-04-18 10:51 ` [patch 1/3] zfcp: fix 31 bit compile warnings Christof Schmitt
2008-04-18 10:51 ` [patch 2/3] zfcp: Remove zfcp_erp_wait from slave destory handler to fix deadlock Christof Schmitt
2008-04-18 10:51 ` Christof Schmitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418105456.235253000@de.ibm.com \
--to=christof.schmitt@de.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mp3@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.