All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.org>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] asoc tlv320aic3x: add GPIO support
Date: Sat, 19 Apr 2008 02:41:03 +0200	[thread overview]
Message-ID: <20080419004103.GA29770@buzzloop.caiaq.de> (raw)
In-Reply-To: <bd7b27490804181326v311f192bi8454c9c0661427d2@mail.gmail.com>

On Fri, Apr 18, 2008 at 11:26:28PM +0300, Jarkko Nikula wrote:
> No any show stopper either but I just started to think about gpiolib if
> AIC3x GPIOs are used as a GPIO.

I agree in general and thought about alternatives as well, but in this
case, it turns out to be a thing the aic3x driver is responsible to as
the registers in questions are purely in its scope. So the idea is to
set up the GPIO's functions via alsa controls and handle its events in
some board-related code as this is really not abstractable. One could,
however, do this setup in machine-related code within the asoc
environment.

My changes don't cast any problems on the existing implementation
either, so I would suggest to just take this patch until someone comes
up with a more suitable solution :)

Best regards,
Daniel

  parent reply	other threads:[~2008-04-19  0:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 18:12 [PATCH] asoc tlv320aic3x: add GPIO support Daniel Mack
     [not found] ` <bd7b27490804181326v311f192bi8454c9c0661427d2@mail.gmail.com>
2008-04-19  0:41   ` Daniel Mack [this message]
2008-04-19 11:24     ` Mark Brown
2008-04-19 12:18       ` Daniel Mack
2008-04-19 14:50         ` Mark Brown
2008-04-19 16:24           ` Daniel Mack
2008-04-19 18:51             ` Mark Brown
2008-04-21 13:41               ` Jarkko Nikula
2008-04-22  9:52             ` Mark Brown
2008-04-22 10:04               ` Daniel Mack
2008-04-22 10:32                 ` Mark Brown
2008-04-21 14:38           ` pHilipp Zabel
2008-04-21 14:51             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080419004103.GA29770@buzzloop.caiaq.de \
    --to=daniel@caiaq.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jhnikula@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.