All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>
Subject: Re: [GIT PATCH] SCSI updates for 2.6.25
Date: Sat, 19 Apr 2008 18:42:02 +0200	[thread overview]
Message-ID: <20080419164202.GA28328@elte.hu> (raw)
In-Reply-To: <1208620484.3280.23.camel@localhost.localdomain>


* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> >  drivers/built-in.o: In function `sas_request_addr':
> >  : undefined reference to `release_firmware'
> > 
> > config can be found at:
> > 
> >    http://redhat.com/~mingo/misc/config-Sat_Apr_19_16_58_35_CEST_2008.bad
> > 
> > ... brought to you by x86.git's randconfig build and boot service ;-)
> 
> This one's fun.  The root cause is 
> 
> CONFIG_SCSI_SAS_LIBSAS=y
> CONFIG_FW_LOADER=m
> 
> The problem is that libsas doesn't depend on the FW loader and doesn't 
> want to.  It just wants to use it if it's available.  The definitions 
> in include/linux/firmware.h have stubs to facilitate this.
> 
> However, CONFIG_FW_LOADER=m defeats the stubs.
> 
> This is a bit nasty to fix; however, I think this patch does.  I've 
> also put a large comment in to explain what's going on.
> 
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

thanks James - your fix works fine here.

Tested-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2008-04-19 16:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 17:41 [GIT PATCH] SCSI updates for 2.6.25 James Bottomley
2008-04-19 15:19 ` Ingo Molnar
2008-04-19 15:54   ` James Bottomley
2008-04-19 16:42     ` Ingo Molnar [this message]
2008-04-19 17:05     ` Adrian Bunk
2008-04-19 17:34       ` James Bottomley
2008-04-19 20:14         ` Linus Torvalds
2008-04-19 20:45           ` Matthew Wilcox
2008-04-20 14:09             ` Stefan Richter
2008-04-20 19:56               ` Matthew Wilcox
2008-04-20 20:14                 ` Stefan Richter
2008-04-28 21:00             ` Sam Ravnborg
2008-04-28 21:01               ` Matthew Wilcox
2008-04-19 22:27           ` James Bottomley
2008-04-19 23:14             ` Matthew Wilcox
2008-04-21 12:51             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080419164202.GA28328@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.