From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JnWXh-0000hR-Qf for mharc-grub-devel@gnu.org; Sun, 20 Apr 2008 06:13:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnWXg-0000gM-6K for grub-devel@gnu.org; Sun, 20 Apr 2008 06:13:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnWXe-0000fN-7g for grub-devel@gnu.org; Sun, 20 Apr 2008 06:13:03 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnWXe-0000fG-0r for grub-devel@gnu.org; Sun, 20 Apr 2008 06:13:02 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JnWXd-0006Rd-MZ for grub-devel@gnu.org; Sun, 20 Apr 2008 06:13:01 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JnWXa-0003Xp-HR for grub-devel@gnu.org; Sun, 20 Apr 2008 12:12:58 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JnWXD-0004RE-PX for grub-devel@gnu.org; Sun, 20 Apr 2008 12:12:35 +0200 Date: Sun, 20 Apr 2008 12:12:35 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080420101235.GB16764@thorin> References: <9749AF5472B1456697B81669920AE810@JerryPC> <20080419213217.GG28507@fencepost.gnu.org> <5F1F44A7E1F44C4BAD769D5F4F7CE197@JerryPC> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5F1F44A7E1F44C4BAD769D5F4F7CE197@JerryPC> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] GRUB2 does not provide Multiboot Legacy memory map X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2008 10:13:04 -0000 On Sat, Apr 19, 2008 at 04:09:15PM -0600, Julian Salazar wrote: > Attached is the patch. Since I'm not completely familiar with GRUB2's > internals, there might be a more efficient way of implementing this. > > Thoughts/improvements? Thanks for the patch. It'd be interesting if it was done portably. The coreboot (aka LinuxBIOS) target also uses this code, and the memory map is obtained differently there (see kern/i386/linuxbios/init.c). At least, it could be #ifdef'ed, although it'd be nice to have something more ellegant (e.g. an isolated, generic function to probe for memory map arch-dependantly that arch-independant code can use). -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)