From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Stringify support commas
Date: Sun, 20 Apr 2008 17:21:24 -0400 [thread overview]
Message-ID: <20080420212124.GA18039@Krystal> (raw)
In-Reply-To: <20080420190631.GA6629@uranus.ravnborg.org>
* Sam Ravnborg (sam@ravnborg.org) wrote:
> On Sun, Apr 20, 2008 at 02:32:56PM -0400, Mathieu Desnoyers wrote:
> > #define MYDEF a, b, c
> >
> > __stringify(MYDEF) should be replaced by "a, b, c", but compilation fails
> > because the __stringify macro expects only one argument. Fix it by using
> > variable macro arguments in __stringify and __stringify_1.
> >
> > Needed in my current NMI safe iret paravirt support work so I can expand
> > a macro containing assembly code into a string.
>
> This is a no-no for those archs that still use -traditional.
> I dunno if this is a problem for you at the moment and the
> right fix is anyway to nuke -traditional.
>
> Sam
A quick grep through arch/ gives me the following :
arch/cris/arch-v10/boot/compressed/Makefile
@$(CC) -D__ASSEMBLY__ -traditional -c $< -o $@
arch/cris/arch-v10/boot/rescue/Makefile
asflags-y += -traditional
arch/cris/arch-v10/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/h8300/boot/compressed/Makefile
EXTRA_AFLAGS := -traditional
arch/m32r/boot/compressed/Makefile
EXTRA_AFLAGS := -traditional
arch/m32r/kernel/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/fpsp040/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/ifpsp060/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/kernel/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/math-emu/Makefile
EXTRA_AFLAGS := -traditional
arch/parisc/kernel/Makefile
AFLAGS_entry.o := -traditional
AFLAGS_pacache.o := -traditional
arch/powerpc/boot/Makefile
BOOTAFLAGS := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc
arch/s390/kernel/Makefile
EXTRA_AFLAGS := -traditional
arch/s390/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/s390/math-emu/Makefile
EXTRA_AFLAGS := -traditional
arch/sh/boot/compressed/Makefile_32
EXTRA_AFLAGS := -traditional
arch/sh/boot/compressed/Makefile_64
EXTRA_AFLAGS := -traditional
Would their removal break something ?
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2008-04-20 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 18:32 [PATCH] Stringify support commas Mathieu Desnoyers
2008-04-20 19:06 ` Sam Ravnborg
2008-04-20 21:21 ` Mathieu Desnoyers [this message]
2008-04-21 6:11 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080420212124.GA18039@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.