From: Bob Copeland <me@bobcopeland.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: akpm@linux-foundation.org, hch@infradead.org,
alan@lxorguk.ukuu.org.uk, miklos@szeredi.hu,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/8] omfs: add inode routines
Date: Sun, 20 Apr 2008 20:41:48 -0400 [thread overview]
Message-ID: <20080421004148.GA7454@hash.localnet> (raw)
In-Reply-To: <20080420095718.GA6079@joi>
On Sun, Apr 20, 2008 at 11:57:22AM +0200, Marcin Slusarz wrote:
> > > +static void set_block_shift(struct omfs_sb_info *sbi)
> > > +{
> > > + unsigned int scale = sbi->s_blocksize / sbi->s_sys_blocksize;
[...]
> > isn't it get_bitmask_order(scale - 1)?
>
> I mean get_bitmask_order(scale >> 1) ;)
Thank you for your comments. Hmm, yeah I think so. It could also
lose the divide:
scale = get_bitmask_order(sbi->s_blocksize) -
get_bitmask_order(sbi->s_sys_blocksize);
(or ffs/fls for that matter.)
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-04-21 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 20:37 [PATCH 3/8] omfs: add inode routines Bob Copeland
2008-04-19 21:28 ` Marcin Slusarz
2008-04-20 9:57 ` Marcin Slusarz
2008-04-21 0:41 ` Bob Copeland [this message]
2008-04-21 15:13 ` Miklos Szeredi
2008-04-22 2:11 ` Bob Copeland
-- strict thread matches above, loose matches on Subject: below --
2008-04-26 21:26 Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421004148.GA7454@hash.localnet \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.