From: Kyle McMartin <kyle@mcmartin.ca>
To: Carlos O'Donell <carlos@systemhalted.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>, linux-parisc@vger.kernel.org
Subject: Re: [PARISC] fix signal trampoline cache flushing
Date: Mon, 21 Apr 2008 11:16:50 -0400 [thread overview]
Message-ID: <20080421151650.GA30767@phobos.i.cabal.ca> (raw)
In-Reply-To: <119aab440804210751g67baf212o786edbc6f9a5168e@mail.gmail.com>
On Mon, Apr 21, 2008 at 07:51:01AM -0700, Carlos O'Donell wrote:
> On Tue, Apr 15, 2008 at 3:36 PM, Kyle McMartin <kyle@mcmartin.ca> wrote:
> > diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c
> > index 58fccc9..06213d1 100644
> > --- a/arch/parisc/kernel/signal.c
> > +++ b/arch/parisc/kernel/signal.c
> > @@ -534,7 +534,8 @@ insert_restart_trampoline(struct pt_regs *regs)
> > * Flushing one cacheline is cheap.
> > * "sync" on bigger (> 4 way) boxes is not.
> > */
> > - flush_icache_range(regs->gr[30], regs->gr[30] + 4);
> > + flush_user_dcache_range(regs->gr[30], regs->gr[30] + 4);
> > + flush_user_icache_range(regs->gr[30], regs->gr[30] + 4);
>
> We also have a restartable syscall trampoline (I think this is unique
> to PA), does that one also need fixing?
>
no.
prev parent reply other threads:[~2008-04-21 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 22:36 [PARISC] fix signal trampoline cache flushing Kyle McMartin
2008-04-21 14:51 ` Carlos O'Donell
2008-04-21 15:16 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421151650.GA30767@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=carlos@systemhalted.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.