All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] gpio-keys debouncing support
Date: Mon, 21 Apr 2008 11:55:16 -0400	[thread overview]
Message-ID: <20080421155516.GD6884@anvil.corenet.prv> (raw)
In-Reply-To: <20080421144019.GA6516@doriath.ww600.siemens.net>

Hi Dmitry,

On Mon, Apr 21, 2008 at 06:40:19PM +0400, Dmitry Baryshkov wrote:
> Hi,
> 
> What about this patch? I still got no comments.
> 

I thought I CCed you form slightly different thread. I don't think that
this should be a separate Kconfig option, we shoudl make it permanent
in the driver. I also wonder if it would be better to allocate debounce
data once for all buttons instead of nickel-and-dime-ing memory
allocator with tiny requests. Timer shoudl be moved into debounce data
too BTW.

Thanks.

-- 
Dmitry

  reply	other threads:[~2008-04-21 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19 22:13 [PATCH] gpio-keys debouncing support Dmitry Baryshkov
2008-04-21 14:40 ` Dmitry Baryshkov
2008-04-21 15:55   ` Dmitry Torokhov [this message]
2008-04-22  1:14     ` Dmitry Baryshkov
2008-04-26 19:14       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080421155516.GD6884@anvil.corenet.prv \
    --to=dmitry.torokhov@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.