From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756771AbYDUQyc (ORCPT ); Mon, 21 Apr 2008 12:54:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752190AbYDUQyX (ORCPT ); Mon, 21 Apr 2008 12:54:23 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:48053 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbYDUQyW (ORCPT ); Mon, 21 Apr 2008 12:54:22 -0400 Date: Mon, 21 Apr 2008 10:54:05 -0600 From: Matthew Wilcox To: Rusty Russell Cc: linux-kernel@vger.kernel.org, Ingo Molnar , "Randy.Dunlap" , Peter Zijlstra , Jonathan Corbet Subject: Re: [DOC PATCH] Remove mention of semaphores from kernel-locking Message-ID: <20080421165405.GB20637@parisc-linux.org> References: <20080421145230.GX20637@parisc-linux.org> <200804220215.30855.rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804220215.30855.rusty@rustcorp.com.au> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2008 at 02:15:30AM +1000, Rusty Russell wrote: > > Three Main Types of Kernel Locks: Spinlocks, Mutexes and > > Semaphores > > > > > > - There are three main types of kernel locks. The fundamental type > > + There are two main types of kernel locks. The fundamental type > > is the spinlock > > (include/asm/spinlock.h), > > which is a very simple single-holder lock: if you can't get the > > Fix title, too? Heh. Oops, thanks. > Thanks for the other fixes too; this document needs some love, No problem ... I started out augmenting it to discuss semaphores and mutexes properly and realised I'd totally overloaded this document with detail. I'm tempted to rip the RCU pieces out of this document and create a new one. What we currently have just doesn't read nicely [1], but this is a project for another day. > Acked, > Rusty. I'll add your ack. Thanks! [1] This seems to be a common problem in Linux's Documentation/ directory ... just _read_ CodingStyle and you can tell which bits are Linus' (funny, deprecating, suggestions) and which bits were added later (stern, prescriptive, fascist). The later bits break the flow of the document and I find them quite jarring. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."