All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helmut Schaa <hschaa@suse.de>
To: linux-wireless@vger.kernel.org
Subject: Question about IEEE80211_PROBE_DELAY
Date: Mon, 21 Apr 2008 18:04:37 +0200	[thread overview]
Message-ID: <200804211804.38060.hschaa@suse.de> (raw)

Hi,

I was just playing around with the mac80211 scan-code and stumbled across 
IEEE80211_PROBE_DELAY. I'm a bit curious why this delay is needed due to the 
fact that any driver can set the channel_change_time to any value it needs.

Therefore I simply removed the IEEE80211_PROBE_DELAY (see below) and only used 
the channel_change_time exposed by the driver. I did some tests with the 
iwl4965 and ath5k (reports AR5213A as chipset) driver and did not notice any 
regression.

Could somebody explain to me if the IEEE80211_PROBE_DELAY is needed anymore 
and for which particular reason?

Thanks,
Helmut

--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -3853,8 +3853,7 @@ void ieee80211_sta_scan_work(struct work_struct *work)
 		if (skip)
 			break;
 
-		next_delay = IEEE80211_PROBE_DELAY +
-			     usecs_to_jiffies(local->hw.channel_change_time);
+		next_delay = usecs_to_jiffies(local->hw.channel_change_time);
 		local->scan_state = SCAN_SEND_PROBE;
 		break;
 	case SCAN_SEND_PROBE:

                 reply	other threads:[~2008-04-21 16:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804211804.38060.hschaa@suse.de \
    --to=hschaa@suse.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.