Hi David, > Patches are welcome - I'd be over the moon if any of the known 4k > stack advocates sent a stack reduction patch for XFS, but it seems > that actually trying to fix the problems is much harder than > resending a one line patch every few months.... kmem_free() function takes (ptr, size) arguments but doesn't actually use second one. This patch removes size argument from all callsites. Code size difference on 32-bit x86: # size */fs/xfs/xfs.o text data bss dec hex filename 391271 2748 1708 395727 609cf linux-2.6-xfs0-TEST/fs/xfs/xfs.o 390739 2748 1708 395195 607bb linux-2.6-xfs1-TEST/fs/xfs/xfs.o Compile-tested only. Signed-off-by: Denys Vlasenko -- vda