From: David Brownell <david-b@pacbell.net>
To: Koen Kooi <k.kooi@student.utwente.nl>
Cc: "Syed Mohammed, Khasim" <khasim@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface
Date: Tue, 22 Apr 2008 09:57:43 -0700 [thread overview]
Message-ID: <200804220957.43599.david-b@pacbell.net> (raw)
In-Reply-To: <03879EA5-591C-4ED6-A3F5-8600F90CC8E7@student.utwente.nl>
On Tuesday 22 April 2008, Koen Kooi wrote:
> --- a/include/asm-arm/arch-omap/board-omap3beagle.h
> +++ b/include/asm-arm/arch-omap/board-omap3beagle.h
> @@ -29,6 +29,8 @@
> #ifndef __ASM_ARCH_OMAP3_BEAGLE_H
> #define __ASM_ARCH_OMAP3_BEAGLE_H
>
> +extern void __init sdp_mmc_init(void);
> +
> #ifdef CONFIG_TWL4030_CORE
>
> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
That's really not the right place to declare shared
routines. Plus of course, since that routine isn't
specific to SDP boards it shouldn't use that name...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-22 16:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 7:57 [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface Koen Kooi
2008-04-22 9:18 ` Syed Mohammed, Khasim
2008-04-22 13:37 ` Koen Kooi
2008-04-22 16:15 ` Koen Kooi
2008-04-22 16:57 ` David Brownell [this message]
2008-04-22 17:00 ` Koen Kooi
2008-04-22 17:07 ` Felipe Balbi
2008-04-23 7:40 ` Koen Kooi
2008-04-24 0:21 ` Tony Lindgren
2008-04-24 19:54 ` Koen Kooi
2008-04-24 20:00 ` Tony Lindgren
2008-04-24 20:37 ` Tony Lindgren
2008-04-24 21:01 ` Koen Kooi
2008-04-25 7:13 ` Dirk Behme
2008-04-25 10:52 ` Felipe Balbi
2008-04-24 1:56 ` Kridner, Jason
2008-04-24 2:20 ` Koen Kooi
2008-04-22 16:32 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804220957.43599.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=k.kooi@student.utwente.nl \
--cc=khasim@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.