From: Ingo Molnar <mingo@elte.hu>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kgdb: fix optional arch functions and probe_kernel_*
Date: Tue, 22 Apr 2008 15:07:20 +0200 [thread overview]
Message-ID: <20080422130720.GA7311@elte.hu> (raw)
In-Reply-To: <480C9F0E.30500@windriver.com>
* Jason Wessel <jason.wessel@windriver.com> wrote:
> >> Still. Do we need the set_fs() in there?
> >> __copy_from_user_inatomic() is a "__" uaccess function and hence
> >> shouldn't be running access_ok()?
> >
> > yeah, i guess that's true. Jason?
>
> In so far as the testing showed, it worked ok on the X86 arch with and
> without the set_fs(), but on ARM it is absolutely required. This
> means we have to decide to make arch specific or leave generic as it
> stands right now.
yeah, i guess so - it's no big issue as this isnt performance critical
in any way. Do you know which exact codepath/mechanism in ARM relies on
the set_fs() being there?
Ingo
prev parent reply other threads:[~2008-04-22 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804181742.m3IHgsoG012669@hera.kernel.org>
2008-04-18 22:48 ` kgdb: fix optional arch functions and probe_kernel_* Andrew Morton
2008-04-21 14:00 ` Ingo Molnar
2008-04-21 14:05 ` Jason Wessel
2008-04-22 13:07 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422130720.GA7311@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.