[ resend: now with patch attached! :) ] Hi David, Seven xfs_trans_XXX functions declared in xfs_trans.h are not using "tp" parameter in non-debug builds, but it still takes stack space since these functions are not static and gcc cannot optimize it out. This patch removes these parameters using #define hack which makes them "disappear" without the need of uglifying every callsite with #ifdefs. Code size difference on 32-bit x86: š393441 š š2904 š š2952 š399297 š 617c1 linux-2.6-xfs7-TEST/fs/xfs/xfs.o š393289 š š2904 š š2952 š399145 š 61729 linux-2.6-xfs8-TEST/fs/xfs/xfs.o Compile tested only. Signed-off-by: Denys Vlasenko -- vda