From: Daniel Jacobowitz <dan@debian.org>
To: David Daney <ddaney@avtrex.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS.
Date: Tue, 22 Apr 2008 12:23:43 -0400 [thread overview]
Message-ID: <20080422162343.GA14790@caradoc.them.org> (raw)
In-Reply-To: <480D33EB.30808@avtrex.com>
On Mon, Apr 21, 2008 at 05:40:11PM -0700, David Daney wrote:
> +struct mips32_watch_regs {
> + unsigned int num_valid;
> + unsigned int reg_mask;
> + unsigned int irw_mask;
> + unsigned long watchlo[8];
> + unsigned int watchhi[8];
> +};
Please do not use long in new ptrace interfaces. Use either
uint32_t or uint64_t as appropriate so that it doesn't depend
on how the kernel or debugger was built.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-04-22 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 23:20 [Patch 0/6] MIPS Hardware watchpoint support for gdb David Daney
2008-04-22 0:01 ` [Patch 1/6] Add HARDWARE_WATCHPOINTS configure option David Daney
2008-04-22 0:10 ` [Patch 2/6] Add HARDWARE_WATCHPOINTS definitions and support code David Daney
2008-04-22 0:15 ` [Patch 3/6] Probe watch registers and report configuration David Daney
2008-04-22 0:21 ` [Patch 4/6] Watch trap handling for HARDWARE_WATCHPOINTS David Daney
2008-04-22 0:33 ` [Patch 5/6] Scheduler support " David Daney
2008-04-22 0:40 ` [Patch 6/6] Ptrace " David Daney
2008-04-22 16:23 ` Daniel Jacobowitz [this message]
2008-04-22 18:26 ` Maciej W. Rozycki
-- strict thread matches above, loose matches on Subject: below --
2008-04-29 1:21 [Patch 0/6] MIPS Hardware watchpoint support for gdb (version 2) David Daney
2008-04-29 1:43 ` [PATCH 6/6] Ptrace support for HARDWARE_WATCHPOINTS David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422162343.GA14790@caradoc.them.org \
--to=dan@debian.org \
--cc=ddaney@avtrex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.