All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Refrain compile warning for lm8323.c
Date: Tue, 22 Apr 2008 12:24:20 -0700	[thread overview]
Message-ID: <20080422192420.GI24257@atomide.com> (raw)
In-Reply-To: <1208870513-13351-1-git-send-email-Hiroshi.DOYU@nokia.com>

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [080422 06:26]:
> drivers/input/keyboard/lm8323.c: In function 'lm8323_pwm_store_time':
> drivers/input/keyboard/lm8323.c:590: warning: passing argument 3 of 'strict_strtoul' from incompatible pointer type
> drivers/input/keyboard/lm8323.c: In function 'lm8323_set_disable':
> drivers/input/keyboard/lm8323.c:664: warning: passing argument 3 of 'strict_strtoul' from incompatible pointer type
> 
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>  drivers/input/keyboard/lm8323.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
> index 3040622..c9ede10 100644
> --- a/drivers/input/keyboard/lm8323.c
> +++ b/drivers/input/keyboard/lm8323.c
> @@ -587,7 +587,7 @@ static ssize_t lm8323_pwm_store_time(struct device *dev,
>  	int ret;
>  	int time;
>  
> -	ret = strict_strtoul(buf, 10, &time);
> +	ret = sscanf(buf, "%d", &time);
>  	/* Numbers only, please. */
>  	if (ret)
>  		return -EINVAL;
> @@ -661,7 +661,7 @@ static ssize_t lm8323_set_disable(struct device *dev,
>  	int ret;
>  	int i;
>  
> -	i = strict_strtoul(buf, 10, &ret);
> +	i = sscanf(buf, "%d", &ret);
>  
>  	mutex_lock(&lm->lock);
>  	lm->kp_enabled = !i;

Pushing.

Tony

      reply	other threads:[~2008-04-22 19:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 13:21 [PATCH] ARM: OMAP: Refrain compile warning for lm8323.c Hiroshi DOYU
2008-04-22 19:24 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080422192420.GI24257@atomide.com \
    --to=tony@atomide.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.