All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC POWERPC] booting-without-of: bindings for FHCI USB, GPIO LEDs, MCU, and NAND on UPM
Date: Wed, 23 Apr 2008 04:37:37 +0400	[thread overview]
Message-ID: <20080423003737.GA11781@zarina> (raw)
In-Reply-To: <1208897422.6654.61.camel@vader.jdub.homelinux.org>

On Tue, Apr 22, 2008 at 03:50:22PM -0500, Josh Boyer wrote:
> On Tue, 2008-04-22 at 14:08 -0600, Grant Likely wrote:
> > On Tue, Apr 22, 2008 at 1:41 PM, Anton Vorontsov
> > <avorontsov@ru.mvista.com> wrote:
> > > Hi all,
> > > +    w) NAND on UPM-driven Freescale Localbus
> > > +
> > > +      Required properties:
> > > +      - compatible : "fsl,upm-nand".
> > > +      - reg : should specify localbus chip select and size used for the chip.
> > > +      - width : should specify port size in bytes.
> > > +      - fsl,upm-addr-offset : UPM pattern offset for the address latch.
> > > +      - fsl,upm-cmd-offset : UPM pattern offset for the command latch.
> > > +      - fsl,wait-pattern : should be present if NAND chip requires waiting
> > > +        for Ready-Not-Busy pin after each executed pattern.
> > > +      - fsl,wait-write : should be present if NAND chip needs waiting on
> > > +        Ready-Not-Busy pin after each write cycle.
> > > +      - linux,chip-delay : optional, may contain delay value in milliseconds
> > > +        (in case when Ready-Not-Busy pin was unspecified).
> > > +      - gpios : may specify optional GPIO connected to the Ready-Not-Busy pin.
> > 
> > I'm not competent to comment on this binding; I haven't spent any time
> > looking at NAND binding conventions.
> 
> That's because there are none, and every time someone proposes one it's
> like this.  Full of weird $board specific stuff that have nothing to do
> with the actual NAND chip.
> 
> For example, why is fsl,wait-write defined as an fsl specific property?
> It seems generic to the NAND chip itself.  Also, why in the example is
> the specific NAND chip part number listed, followed by fsl,upm-nand?
> It's almost as if people want to mix the NAND chip and NAND controller
> definitions together.  Maybe there is a good reason for it, but it's
> really confusing.

Much thanks for the idea, I should indeed separate UPM NAND controller
and NAND chip itself.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2008-04-23  0:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 19:41 [RFC POWERPC] booting-without-of: bindings for FHCI USB, GPIO LEDs, MCU, and NAND on UPM Anton Vorontsov
2008-04-22 20:08 ` Grant Likely
2008-04-22 20:20   ` Scott Wood
2008-04-22 20:26     ` Grant Likely
2008-04-22 20:50   ` Josh Boyer
2008-04-23  0:37     ` Anton Vorontsov [this message]
2008-04-23  0:37   ` Anton Vorontsov
2008-04-23  3:22     ` Grant Likely
2008-04-23  9:15 ` Laurent Pinchart
2008-04-23 14:01   ` Anton Vorontsov
2008-04-24 17:52 ` [RFCv2 " Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080423003737.GA11781@zarina \
    --to=cbouatmailru@gmail.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.