From: Pete Zaitcev <zaitcev@redhat.com>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Ingo Molnar" <mingo@elte.hu>, "Frans Pop" <elendil@planet.nl>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@suse.de, "Christoph Lameter" <clameter@sgi.com>
Subject: Re: [sched-devel/latest] WARNING: at mm/slub.c:2443
Date: Wed, 23 Apr 2008 10:13:11 -0700 [thread overview]
Message-ID: <20080423101311.d7420a13.zaitcev@redhat.com> (raw)
In-Reply-To: <84144f020804230034y3d31fb02n597b69d7ed866260@mail.gmail.com>
On Wed, 23 Apr 2008 10:34:57 +0300, "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:
> On Wed, Apr 23, 2008 at 10:31 AM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> > On Wed, Apr 23, 2008 at 9:51 AM, Pete Zaitcev <zaitcev@redhat.com> wrote:
> > > I looked at this whole day today, but found nothing.
> > >
> > > The code analysis for usbmon shows nothing. Anyone wants to have
> > > a look?
>
> > I didn't look too closely but mon_text_fetch() does list_del() but no
> > kmem_cache_free() which looks fishy.
>
> Yup, looks like a leak in the error path. So it's mon_text_read_t() ->
> mon_text_read_wait() -> mon_text_fetch() that removes it from the list
> but we can fail before we reach the kmem_cache_free() in
> mon_text_read_t() and thus lose track of the object.
This is false, we cannot fail. There's only one "return" for non-NULL
case and the kmem_cache_free is right in front of it. See my reply
to the patch.
-- Pete
next prev parent reply other threads:[~2008-04-23 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 21:10 [sched-devel/latest] WARNING: at mm/slub.c:2443 Frans Pop
2008-04-22 13:40 ` Ingo Molnar
2008-04-22 17:27 ` Pekka J Enberg
2008-04-22 19:22 ` Christoph Lameter
2008-04-22 21:32 ` Pete Zaitcev
2008-04-23 5:21 ` Pekka J Enberg
2008-04-23 6:51 ` Pete Zaitcev
2008-04-23 7:31 ` Pekka Enberg
2008-04-23 7:34 ` Pekka Enberg
2008-04-23 17:13 ` Pete Zaitcev [this message]
2008-04-23 7:38 ` Pekka J Enberg
2008-04-23 17:11 ` Pete Zaitcev
2008-04-23 17:35 ` Pekka Enberg
2008-04-23 18:15 ` Frans Pop
2008-04-24 14:13 ` Frans Pop
2008-05-02 9:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423101311.d7420a13.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=clameter@sgi.com \
--cc=elendil@planet.nl \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.