All of lore.kernel.org
 help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: petkovbb@gmail.com
Cc: bzolnier@gmail.com, fujita.tomonori@lab.ntt.co.jp,
	linux-ide@vger.kernel.org, jens.axboe@oracle.com
Subject: Re: [PATCH 00/11] removing the on-stack struct request
Date: Wed, 23 Apr 2008 17:25:15 +0900	[thread overview]
Message-ID: <20080423172500J.tomof@acm.org> (raw)
In-Reply-To: <20080423074010.GA8221@gollum.tnic>

On Wed, 23 Apr 2008 09:40:11 +0200
Borislav Petkov <petkovbb@googlemail.com> wrote:

> On Tue, Apr 22, 2008 at 11:14:28AM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> [..]
> 
> > Looks promising but probably I'll not be able to review it properly
> > this week (I'm busy with my real job) and the next week (I'll be busy
> > with pushing overdue IDE updates).  OTOH I'm hoping that Borislav
> > would be able to take a look in the meantime.
> 
> Yep, they're quite straight-forward and look fine except some nitpicking i sent
> in separate mails.

Thanks for reviewing,

Yeah, these patches are pretty straightforward mainly because they are
against the paths where we can use __GFP_WAIT.


> FWIW, this is what we wanted to do initially but Jens didn't
> agree to that at the time. I guess, it's because i probably didn't express
> myself clearly enough then. See http://kerneltrap.org/mailarchive/linux-kernel/2008/3/1/1037974
> for the whole discussion.

I think that IDE uses request struct from interrupt context at some
places. In such places, I don't think that converting requests on the
stack and a pre-allocated fixed number of requests to
kmalloc/blk_get_request with GFP_ATOMIC is an good idea. It's better
to remove such code (allocating requests from interrupt context).



  parent reply	other threads:[~2008-04-23  8:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22  0:26 [PATCH 00/11] removing the on-stack struct request FUJITA Tomonori
2008-04-22  0:26 ` [PATCH 01/11] ide: use blk_get_request in the ide_do_drive_cmd path using ide_wait FUJITA Tomonori
2008-04-22  0:26   ` [PATCH 02/11] ide-floppy: use blk_get_request in the ide_do_drive_cmd path FUJITA Tomonori
2008-04-22  0:26     ` [PATCH 03/11] ide-taskfile: " FUJITA Tomonori
2008-04-22  0:26       ` [PATCH 04/11] ide-disk: " FUJITA Tomonori
2008-04-22  0:26         ` [PATCH 05/11] ide-cd: convert ide_cd_queue_pc to use blk_get_request FUJITA Tomonori
2008-04-22  0:26           ` [PATCH 06/11] ide: make ide_do_drive_cmd return rq->errors FUJITA Tomonori
2008-04-22  0:26             ` [PATCH 07/11] ide-tape: use blk_get_request in the ide_do_drive_cmd path FUJITA Tomonori
2008-04-22  0:26               ` [PATCH 08/11] ide-cd: " FUJITA Tomonori
2008-04-22  0:26                 ` [PATCH 09/11] ide: call blk_put_request properly FUJITA Tomonori
2008-04-22  0:26                   ` [PATCH 10/11] block: convert pd to use blk_get_request FUJITA Tomonori
2008-04-22  0:26                     ` [PATCH 11/11] block: remove the checking for NULL queue in blk_put_request FUJITA Tomonori
2008-04-23  7:31               ` [PATCH 07/11] ide-tape: use blk_get_request in the ide_do_drive_cmd path Borislav Petkov
2008-04-23  8:25                 ` FUJITA Tomonori
2008-04-23 10:20                   ` Boris Petkov
2008-04-23  7:32             ` [PATCH 06/11] ide: make ide_do_drive_cmd return rq->errors Borislav Petkov
2008-04-23  8:25               ` FUJITA Tomonori
2008-04-23 10:27                 ` Boris Petkov
2008-04-22  9:14 ` [PATCH 00/11] removing the on-stack struct request Bartlomiej Zolnierkiewicz
2008-04-23  7:40   ` Borislav Petkov
2008-04-23  7:43     ` Jens Axboe
2008-04-23  8:25     ` FUJITA Tomonori [this message]
2008-04-23  8:27       ` Jens Axboe
2008-04-23 10:32         ` Boris Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080423172500J.tomof@acm.org \
    --to=fujita.tomonori@lab.ntt.co.jp \
    --cc=bzolnier@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.