From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: tomas.winkler@intel.com, torvalds@linux-foundation.org,
yi.zhu@intel.com, reinette.chatre@intel.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] iwlwifi: Fix built-in compilation of iwlcore
Date: Wed, 23 Apr 2008 16:51:59 -0400 [thread overview]
Message-ID: <20080423205159.GB30048@tuxdriver.com> (raw)
In-Reply-To: <20080423.034943.15067739.davem@davemloft.net>
On Wed, Apr 23, 2008 at 03:49:43AM -0700, David Miller wrote:
> From: Tomas Winkler <tomas.winkler@intel.com>
> > --- a/drivers/net/wireless/iwlwifi/Makefile
> > +++ b/drivers/net/wireless/iwlwifi/Makefile
> > @@ -1,4 +1,4 @@
> > -obj-$(CONFIG_IWLCORE) := iwlcore.o
> > +obj-$(CONFIG_IWLCORE) += iwlcore.o
> > iwlcore-objs := iwl-core.o iwl-eeprom.o iwl-hcmd.o iwl-power.o
>
> I had to apply this patch by hand because "iwl-power.o" is not
> present in the iwlcore-objs line in the current tree.
>
> Does it exist in John's wireless tree or something like that? This
> new iwl-power.o object looks like it would be new code and a new
> feature, which we wouldn't be able to add into the tree at this time
> as all networking new features have gone into the merge window
> already.
FWIW, I don't have an iwl-power.c either. Please be careful to
send patches against the actual upstream tree rather than a working
tree. :-)
> To expedite getting this bug fix applied, I've added this fix
> by hand and will push it to Linus tonight.
Thanks, Dave!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-04-23 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 10:38 [PATCH 1/1] iwlwifi: Fix built-in compilation of iwlcore Tomas Winkler
2008-04-23 10:49 ` David Miller
2008-04-23 20:51 ` John W. Linville [this message]
2008-04-23 23:30 ` Chatre, Reinette
2008-04-24 2:31 ` [PATCH] iwlwifi: Fix built-in compilation of iwlcore (part 2) Zhu Yi
2008-04-24 2:43 ` David Miller
2008-04-24 2:58 ` Zhu Yi
-- strict thread matches above, loose matches on Subject: below --
2008-04-23 10:58 [PATCH 1/1] iwlwifi: Fix built-in compilation of iwlcore Tomas Winkler
2008-04-23 11:00 ` David Miller
2008-04-23 11:02 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423205159.GB30048@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tomas.winkler@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.