From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: xemul@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH][NETNS]: The ip6_fib_timer can work with garbage on net namespace stop.
Date: Thu, 24 Apr 2008 01:03:08 -0700 (PDT) [thread overview]
Message-ID: <20080424.010308.62149951.davem@davemloft.net> (raw)
In-Reply-To: <20080424.011406.109706186.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Thu, 24 Apr 2008 01:14:06 +0900 (JST)
> In article <480C912E.70900@openvz.org> (at Mon, 21 Apr 2008 17:05:50 +0400), Pavel Emelyanov <xemul@openvz.org> says:
>
> > The del_timer() function doesn't guarantee, that the timer callback
> > is not active by the time it exits.
> >
> > Thus, the fib6_net_exit() may kfree() all the data, that is required
> > by the fib6_run_gc(). The race window is tiny, but slab poisoning can
> > trigger this bug.
> >
> > Using del_timer_sync() will cure this.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
>
> Also suitable for -stable.
I will queue it, thanks.
prev parent reply other threads:[~2008-04-24 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 13:05 [PATCH][NETNS]: The ip6_fib_timer can work with garbage on net namespace stop Pavel Emelyanov
2008-04-21 21:23 ` David Miller
2008-04-23 16:14 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 8:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424.010308.62149951.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.