From: David Chinner <dgc@sgi.com>
To: Timothy Shimmin <tes@sgi.com>
Cc: David Chinner <dgc@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported
Date: Thu, 24 Apr 2008 16:58:22 +1000 [thread overview]
Message-ID: <20080424065822.GY103491721@sgi.com> (raw)
In-Reply-To: <480EDE04.5080003@sgi.com>
On Wed, Apr 23, 2008 at 04:58:12PM +1000, Timothy Shimmin wrote:
> Hi,
>
> _test_punch already does a umount $SCRATCH_MNT.
> However, IMHO, it would probably be nicer if one could
> use a _require_dmapi or really it may be simpler if
> we could roll it into common.dmapi
> so one just needs to include common.dmapi and
> it would complain at that point if the kernel
> didn't support it.
Sure, but we don't have that, and I'm not about to spend the time to
convert >20 tests to something like this. Right now I just want to
remove all the bloody silly test failures on mainline kernels.
All the other dmapi tests "not run" just fine, I want these to do
the same thing. Is that good enough to check in right now?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-04-24 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 1:38 [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported David Chinner
2008-04-23 6:58 ` Timothy Shimmin
2008-04-24 6:58 ` David Chinner [this message]
2008-04-28 0:09 ` Timothy Shimmin
2008-04-29 0:22 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424065822.GY103491721@sgi.com \
--to=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.