All of lore.kernel.org
 help / color / mirror / Atom feed
From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
	Ursula Braun <braunu@de.ibm.com>
Subject: [patch 02/11] netiucv: get rid of in_atomic() use
Date: Thu, 24 Apr 2008 10:15:19 +0200	[thread overview]
Message-ID: <20080424081902.526059000@de.ibm.com> (raw)
In-Reply-To: 20080424081517.987104000@de.ibm.com

[-- Attachment #1: 701-netiucv-inatomic.diff --]
[-- Type: text/plain, Size: 934 bytes --]

From: Ursula Braun <braunu@de.ibm.com>

There is no urgent need to restart a netiucv connection automatically,
if packets are sent while the netiucv device is not up and running.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---

 drivers/s390/net/netiucv.c |    2 --
 1 file changed, 2 deletions(-)

diff -urpN linux-2.6/drivers/s390/net/netiucv.c linux-2.6-patched/drivers/s390/net/netiucv.c
--- linux-2.6/drivers/s390/net/netiucv.c	2008-04-23 17:52:28.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/netiucv.c	2008-04-23 17:55:48.000000000 +0200
@@ -1313,8 +1313,6 @@ static int netiucv_tx(struct sk_buff *sk
 	 * and throw away packet.
 	 */
 	if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
-		if (!in_atomic())
-			fsm_event(privptr->fsm, DEV_EVENT_START, dev);
 		dev_kfree_skb(skb);
 		privptr->stats.tx_dropped++;
 		privptr->stats.tx_errors++;

-- 

  parent reply	other threads:[~2008-04-24  8:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24  8:15 [patch 00/11] s390: network device driver fixes for 2.6.26 frank.blaschka
2008-04-24  8:15 ` [patch 01/11] lcs: CCL-sequ. numbers required for protocol 802.2 only frank.blaschka
2008-04-29  5:59   ` Jeff Garzik
2008-04-24  8:15 ` frank.blaschka [this message]
2008-04-24  8:15 ` [patch 03/11] ccwgroup: Unify parsing for group attribute frank.blaschka
2008-04-24  8:15 ` [patch 04/11] qeth module size reduction frank.blaschka
2008-04-24  8:15 ` [patch 05/11] qeth: layer 3 support vlan IPv6 on hiper socket frank.blaschka
2008-04-24  8:15 ` [patch 06/11] qeth: provide get ethtool settings frank.blaschka
2008-04-24  8:15 ` [patch 07/11] qeth: rework fast path frank.blaschka
2008-04-24  8:15 ` [patch 08/11] qeth: layer 3 add missing dev_open/close to ccwgroup handler frank.blaschka
2008-04-24  8:15 ` [patch 09/11] qeth: read number of ports from card frank.blaschka
2008-04-24  8:15 ` [patch 10/11] qeth: layer 2 allow ethtool to set TSO frank.blaschka
2008-04-24  8:15 ` [patch 11/11] netiucv: Fix missing driver attributes frank.blaschka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424081902.526059000@de.ibm.com \
    --to=frank.blaschka@de.ibm.com \
    --cc=braunu@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.