From: Cyrill Gorcunov <gorcunov@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs
Date: Thu, 24 Apr 2008 12:42:41 +0400 [thread overview]
Message-ID: <20080424084241.GA8624@cvg> (raw)
In-Reply-To: <1209026364.9212.978.camel@pmac.infradead.org>
[David Woodhouse - Thu, Apr 24, 2008 at 09:39:24AM +0100]
| On Thu, 2008-04-24 at 12:35 +0400, Cyrill Gorcunov wrote:
| > X86_VM_MASK is a kernel specific flag so lets hide it from
| > userland programs
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
|
| Since and there's already an #ifdef __KERNEL__ section later on in the
| file, and since X86_VM_MASK isn't used before that, I probably would
| have been inclined to shift it down there instead of adding a new
| #ifdef.
|
| But maybe I should just stop heckling... :)
|
| --
| dwmw2
|
I was thought about that too ;) David, I'll recheck this
all today evening (have to go to office now). And please
continue heckling - it allows to make this file in particular
*better*, so I think it's ok ;)
- Cyrill -
prev parent reply other threads:[~2008-04-24 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 8:35 [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs Cyrill Gorcunov
2008-04-24 8:39 ` David Woodhouse
2008-04-24 8:42 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424084241.GA8624@cvg \
--to=gorcunov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.