From: "John W. Linville" <linville@tuxdriver.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Roel Kluin <12o3l@tiscali.nl>,
linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0.
Date: Thu, 24 Apr 2008 08:16:13 -0400 [thread overview]
Message-ID: <20080424121613.GA3879@tuxdriver.com> (raw)
In-Reply-To: <20080424122628.zioaht24o4ko4ww8@naisho.dyndns.info>
On Thu, Apr 24, 2008 at 12:26:28PM +0300, Jussi Kivilinna wrote:
> Quoting Johannes Berg <johannes@sipsolutions.net>:
>
>>
>> Eh, why not make the modparam unsigned and default to 500?
>>
>> johannes
>>
>
> Now that I stop and think about it, that would be better option. The
> modparam already has default value of 500.
>
> Reason why workaround modparam is signed, is that value -1 did have some
> functionality in some early version. That then changed and
> priv->param_workaround_interval changed to unsigned and forgot about
> modparam.
I merged the patch, so if you want that behavior we need a new patch.
John
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2008-04-24 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:10 [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0 Roel Kluin
2008-04-24 6:16 ` Jussi Kivilinna
2008-04-24 8:57 ` Johannes Berg
2008-04-24 9:26 ` Jussi Kivilinna
2008-04-24 12:16 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424121613.GA3879@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=12o3l@tiscali.nl \
--cc=johannes@sipsolutions.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.