All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org
Subject: [patch 08/15] m68k: macide doesnt check for Mac
Date: Thu, 24 Apr 2008 20:29:48 +0200	[thread overview]
Message-ID: <20080424183242.456519997@mail.of.borg> (raw)
In-Reply-To: 20080424182940.424312704@mail.of.borg

[-- Attachment #1: m68k-macide-breaks-multi-platform.diff --]
[-- Type: text/plain, Size: 893 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>

The Macintosh IDE driver (macide) doesn't check whether it's actually running
on Mac hardware, causing a crash if it isn't.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ide/legacy/macide.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/ide/legacy/macide.c
+++ b/drivers/ide/legacy/macide.c
@@ -95,6 +95,9 @@ static int __init macide_init(void)
 	int irq;
 	hw_regs_t hw;
 
+	if (!MACH_IS_MAC)
+		return -ENODEV;
+
 	switch (macintosh_config->ide_type) {
 	case MAC_IDE_QUADRA:
 		base = IDE_BASE;

-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


  parent reply	other threads:[~2008-04-24 18:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 18:29 [patch 00/15] m68k patches for 2.6.26 Geert Uytterhoeven
2008-04-24 18:29 ` [patch 01/15] m68k: Convert access_ok() to an inline function Geert Uytterhoeven
2008-04-24 18:29 ` [patch 02/15] m68k: Kill CONFIG_FB_DAFB Geert Uytterhoeven
2008-04-24 18:29   ` Geert Uytterhoeven
2008-04-24 18:29 ` [patch 03/15] m68k: FB_HP300 depends on DIO and doesnt need FB_CFB_FILLRECT Geert Uytterhoeven
2008-04-24 18:29   ` Geert Uytterhoeven
2008-04-24 18:29 ` [patch 04/15] m68k: Kill CONFIG_WHIPPET_SERIAL Geert Uytterhoeven
2008-04-24 18:29 ` [patch 05/15] m68k vme_scc: avoid global namespace pollution Geert Uytterhoeven
2008-04-24 18:29 ` [patch 06/15] m68k: Make gcc aware that BUG() does not return Geert Uytterhoeven
2008-04-24 18:29 ` [patch 07/15] m68k: Correct jump if not running on HP300 Geert Uytterhoeven
2008-04-24 18:29 ` Geert Uytterhoeven [this message]
2008-04-24 18:29 ` [patch 09/15] m68k: dnfb doesnt check for Apollo Geert Uytterhoeven
2008-04-24 18:29   ` Geert Uytterhoeven
2008-04-24 18:29 ` [patch 10/15] m68k: Some network drivers do not check the platform Geert Uytterhoeven
2008-04-24 18:42   ` Christoph Hellwig
2008-04-24 18:51     ` Geert Uytterhoeven
2008-04-24 17:54       ` Brad Boyer
2008-04-24 18:53       ` Christoph Hellwig
2008-04-24 18:29 ` [patch 11/15] m68k: Some input " Geert Uytterhoeven
2008-04-24 18:29   ` Geert Uytterhoeven
2008-04-24 18:29 ` [patch 12/15] m68k: Return -ENODEV if no device is found Geert Uytterhoeven
2008-04-24 18:29 ` [patch 13/15] m68k: Q40/Q60 floppy support is broken Geert Uytterhoeven
2008-04-24 18:29 ` [patch 14/15] m68k: Update defconfigs Geert Uytterhoeven
2008-04-24 21:11   ` Joel Becker
2008-04-25  7:29     ` Geert Uytterhoeven
2008-04-24 18:29 ` [patch 15/15] m68k: Add multi_defconfig Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424183242.456519997@mail.of.borg \
    --to=geert@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.