From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org
Subject: Re: [XFRM]: alg_key_len & alg_icv_len should be unsigned
Date: Fri, 25 Apr 2008 00:29:42 -0700 (PDT) [thread overview]
Message-ID: <20080425.002942.44065218.davem@davemloft.net> (raw)
In-Reply-To: <20080425071419.GA17997@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 25 Apr 2008 15:14:20 +0800
> On Fri, Apr 25, 2008 at 09:09:05AM +0200, Eric Dumazet wrote:
> > In commit ba749ae98d5aa9d2ce9a7facde0deed454f92230 ([XFRM]: alg_key_len
> > should be unsigned to avoid integer divides
> > <http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=ba749ae98d5aa9d2ce9a7facde0deed454f92230>)
> > alg_key_len field of struct xfrm_algo was converted to unsigned int to
> > avoid integer divides.
> >
> > Then Herbert in commit 1a6509d991225ad210de54c63314fd9542922095
> > ([IPSEC]: Add support for combined mode algorithms) added a new
> > structure xfrm_algo_aead, that resurrected a signed int for alg_key_len
> > and re-introduce integer divides.
> >
> > This patch avoids these divides and saves 64 bytes of text on i386.
> >
> > Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> I actually wrote my patch before yours was merged which was why
> it was signed.
Applied, thanks everyone.
prev parent reply other threads:[~2008-04-25 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 7:09 [XFRM]: alg_key_len & alg_icv_len should be unsigned Eric Dumazet
2008-04-25 7:14 ` Herbert Xu
2008-04-25 7:17 ` Eric Dumazet
2008-04-25 7:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425.002942.44065218.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.