From: Rusty Russell <rusty@rustcorp.com.au>
To: Adrian Bunk <bunk@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] x86: Fix non-kernel use of include/linux/types.h
Date: Fri, 25 Apr 2008 05:20:38 +1000 [thread overview]
Message-ID: <200804250520.39124.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080424160101.GA18854@cs181133002.pp.htv.fi>
On Friday 25 April 2008 02:01:01 Adrian Bunk wrote:
> On Fri, Apr 25, 2008 at 01:14:38AM +1000, Rusty Russell wrote:
> > In file included from ../../include/linux/if_tun.h:21,
> > from lguest.c:30:
> > ../../include/linux/types.h:203: error: expected specifier-qualifier-list
> > before ‘__kernel_daddr_t’
> >
> > This reversion was created by e40c0fe6b0b5dd16aec3c0dad311d36b19d78fd9
> > 'x86: cleanup duplicate includes' which removed the !__KERNEL__ case from
> > asm-x86/posix_types.h.
>
> I'd actually prefer my patch [1] that:
> - reverts to the 2.6.24 status quo since we shouldn't leak CONFIG_* to
> userspace at all and
> - also fixes the same regression in unistd.h
Yep, prefer your patch too.
Cheers,
Rusty.
prev parent reply other threads:[~2008-04-24 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 15:14 [PATCH] x86: Fix non-kernel use of include/linux/types.h Rusty Russell
2008-04-24 16:01 ` Adrian Bunk
2008-04-24 19:20 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804250520.39124.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=bunk@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.