From: Jean Delvare <khali@linux-fr.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: alek.du@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support
Date: Sat, 26 Apr 2008 11:17:33 +0200 [thread overview]
Message-ID: <20080426111733.135e3f0a@hyperion.delvare> (raw)
In-Reply-To: <20080425231001.97cabebc.akpm@linux-foundation.org>
On Fri, 25 Apr 2008 23:10:01 -0700, Andrew Morton wrote:
> I worry about the inclusion of apm_bios.h. The driver is configured to be
> available on all architectures but apm_bios.h is surely x86-specific (and
> maybe mips).
>
> But afaict the inclusion is not needed?
Indeed not. It was copied from i2c-piix4, which includes it since the
beginning of times for no good reason. I just posted a patch fixing
i2c-piix4:
http://lists.lm-sensors.org/pipermail/i2c/2008-April/003414.html
--
Jean Delvare
next prev parent reply other threads:[~2008-04-26 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 2:04 [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support alek du
2008-04-23 12:32 ` Jean Delvare
2008-04-24 1:33 ` Alek Du
2008-04-26 6:10 ` Andrew Morton
2008-04-26 9:17 ` Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-22 2:16 alek du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080426111733.135e3f0a@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.